Virtual routing fix #224
Merged
Virtual routing fix #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new improvements
Add all new commits
|
You are on fire @DeMoorJasper! 🙌👏 Sent with GitHawk |
devongovett
requested changes
Dec 20, 2017
src/assets/HTMLAsset.js
Outdated
| @@ -45,6 +45,10 @@ class HTMLAsset extends Asset { | |||
| if (node.attrs) { | |||
| for (let attr in node.attrs) { | |||
| let elements = ATTRS[attr]; | |||
| // link is not a file | |||
| if (node.tag === 'a' && node.attrs[attr].lastIndexOf('.') < 1) { | |||
There was a problem hiding this comment.
Maybe we should just ignore all absolute paths within HTML instead? so just check if the first character is /?
There was a problem hiding this comment.
Wouldn't this also break any absolute path require, (this has already been reported as a bug)?
There was a problem hiding this comment.
Not sure why you'd want to require an absolute path so this might be ok.
|
Conflicts have been fixed @brandon93s |
devongovett
approved these changes
Jan 3, 2018
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
* run prettier * potential fix * fix relative paths * switch to last index to still support relative paths on legit assets * add test * fix failing test
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
* run prettier * potential fix * fix relative paths * switch to last index to still support relative paths on legit assets * add test * fix failing test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
potential fix for closes #211